Fixes Figures URL wildcard placement #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that the router URLs were included after the wildcard url pattern. This should fix the issue
OmarIthawi
approved these changes
Nov 18, 2020
| @@ -139,3 +139,5 @@ | |||
| urlpatterns.append(url(r'^api/', include(router.urls, namespace='api'))) | |||
| else: | |||
| urlpatterns.append(url(r'^api/', include((router.urls, 'api'), namespace='api'))) | |||
|
|
|||
| urlpatterns.append(url(r'^(?:.*)/?$', views.figures_home, name='router-catch-all')) | |||
There was a problem hiding this comment.
Suggested change
| urlpatterns.append(url(r'^(?:.*)/?$', views.figures_home, name='router-catch-all')) | |
| # Reroute all unmatched traffic to Figures main UI page | |
| urlpatterns.append(url(r'^(?:.*)/?$', views.figures_home, name='router-catch-all')) |
figures/urls.py
Outdated
| @@ -129,7 +129,7 @@ | |||
| name='general-site-metrics'), | |||
|
|
|||
| # Reroute all unmatched traffic to Figures main UI page | |||
| url(r'^(?:.*)/?$', views.figures_home, name='router-catch-all') | |||
| # url(r'^(?:.*)/?$', views.figures_home, name='router-catch-all') | |||
There was a problem hiding this comment.
Suggested change
| # url(r'^(?:.*)/?$', views.figures_home, name='router-catch-all') |
figures/urls.py
Outdated
| @@ -129,7 +129,7 @@ | |||
| name='general-site-metrics'), | |||
|
|
|||
| # Reroute all unmatched traffic to Figures main UI page | |||
There was a problem hiding this comment.
Suggested change
| # Reroute all unmatched traffic to Figures main UI page |
johnbaldwin
force-pushed
the
john/fix-url-wildcard
branch
from
1554552 to
f72fe2e
Compare
|
Thanks, Omar! |
melvinsoft
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the router URLs were included after the wildcard url
pattern. This should fix the issue