Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMS Push notifications issues #644

Closed
hilariocoelho opened this issue Nov 25, 2021 · 2 comments
Closed

HMS Push notifications issues #644

hilariocoelho opened this issue Nov 25, 2021 · 2 comments
Labels
bug

Comments

@hilariocoelho
Copy link
Contributor

While using HMS Push notifications with GoRush 1.14.0 I've identified some issues.

The first one was GoRush doesn't send AndroidNotification data when huawei_data is sent

After fixing it I've faced another issue: foreground_show variable was not being sent with false to HMS services which leads to the application always showing OS notification even when it is in foreground.

The first issue is fixed by removing this else.

The second issue depends on a fix on github.com/msalihkarakasli/go-hms-push lib. I already created a PR to fix it.

This issue is probably related to #615
@hilariocoelho hilariocoelho mentioned this issue Nov 25, 2021
Merged
@appleboy
Copy link
Owner

appleboy commented Dec 9, 2021

fixed in #645 Please try the latest version.

@appleboy appleboy closed this as completed Dec 9, 2021
@appleboy appleboy added the bug label Dec 9, 2021
@hilariocoelho
Copy link
Contributor Author

Just tested latest version, seems to be working properly for my use case! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@appleboy @hilariocoelho