Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] ManagedBuffer: rename Value => Header #3374

Merged
merged 1 commit into from
Jul 12, 2016
Merged

[stdlib] ManagedBuffer: rename Value => Header #3374

merged 1 commit into from
Jul 12, 2016

Conversation

dabrahams
Copy link
Contributor

@dabrahams dabrahams commented Jul 7, 2016

This implements SE-0114 Updating Buffer "Value" Names to "Header" Names
https://github.com/apple/swift-evolution/blob/master/proposals/0114-buffer-naming.md


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

This implements SE-0114 Updating Buffer "Value" Names to "Header" Names
https://github.com/apple/swift-evolution/blob/master/proposals/0114-buffer-naming.md

@dabrahams
Copy link
Contributor Author

@swift-ci Please test and merge

2 similar comments
@dabrahams
Copy link
Contributor Author

@swift-ci Please test and merge

@dabrahams
Copy link
Contributor Author

@swift-ci Please test and merge

@dabrahams
Copy link
Contributor Author

Whatever is failing this test has nothing to do with this change, so merging.

@dabrahams dabrahams merged commit e1e739f into master Jul 12, 2016
@dabrahams dabrahams deleted the SE-0114 branch July 12, 2016 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant