Automatically generate leading/trailing space trivia for tokens in SyntaxFactory
#473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
approved these changes
Jun 25, 2022
|
@swift-ci please test |
fwcd
commented
Jun 25, 2022
There was a problem hiding this comment.
A few notes on the implementation below. The open keyword also still needs an explicit trailing trivia call (in TokensFile.swift:100) since contextual keywords as generated in makeContextualKeyword apparently do not require a trailing space.
|
@swift-ci please test |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
ahoppen
approved these changes
Jun 27, 2022
Additionally, remove redundant trivia generation from TokensFile and no longer needed leading/trailing space info from Tokens in SwiftSyntaxBuilderGeneration. Since SyntaxFactory now takes care of leading/trailing spaces, we no longer need these helpers (that were previously required by the TokensFile template).
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to clean up the
TokensFiletemplate inSwiftSyntaxBuilderGeneration, this branch moves the generation of leading/trailing space trivia around tokens intoSyntaxFactory. In other words, calls likewill now automatically generate a trailing space (although this is still overridable by explicitly passing
trailingTrivia: []as a parameter).cc @ahoppen