Conform Array to various ExpressibleAs protocols in BuildableCollectionNodes
#461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
force-pushed
the
buildable-collections-array-conformances
branch
from
5909717 to
4726f15
Compare
|
@swift-ci please test |
kimdv
approved these changes
Jun 9, 2022
ahoppen
reviewed
Jun 9, 2022
Always use existential expressible types in Array conformance bounds. This lets us use heterogenous arrays and matches the initializers of the actual structures. Add some tests for the new Array conformances.
fwcd
force-pushed
the
buildable-collections-array-conformances
branch
from
4726f15 to
93b7852
Compare
|
Sure, I've added a few tests. Additionally, I have updated the conformance clause to always test for equality against the element type, i.e. use existentials. This is slightly more flexible and more consistent with the existing initializers e.g. in |
|
@swift-ci please test |
This was referenced Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a separate PR (from #460) for easier reviewability. This adds a bunch of
Arrayconformances that let us initialize syntax collections more conveniently, for example:instead of
(This applies whenever the parameter has an existential type a la
ExpressibleAsModifierList, in which case the compiler cannot infer that we would like to use theExpressibleByArrayLiteralconformance fromModifierList)cc @ahoppen