Extract syntax builder generation templates into separate directory #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Hi @fwcd and welcome! 👋 Could you squash the commits into a single commit and then push? |
|
Sure, is everything fine as is? My thinking was to leave them separated until the PR is fully reviewed and mergeable. |
kimdv
reviewed
Jun 5, 2022
|
@swift-ci Please test |
- Extract Tokens SourceFile into separate file - Move syntax builder templates into subfolder - Reformat TokensFile for readability - Rename to SyntaxUtilities
|
@swift-ci Please test |
|
Could we merge this? |
|
Yea if it's green and approved. |
|
I don't have commit access, but I have chatted with @ahoppen earlier, this should be ready to go. |
|
🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch aims to introduce a consistent directory layout for the
SourceFiletemplates from the newSwiftSyntaxBuilderGenerationmodule by moving theTokens.swifttemplate into a subdirectory namedTemplates:Additionally, I have reformatted the file with slightly more readable indentation.
cc @ahoppen @kimdv