-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the api check. #1670
Update the api check. #1670
Conversation
- With `main` now being used for releases, just need to check against the last release. - Remove all the known breaks issues as we've done a release and thus reset the list.
@gjcairo @FranzBusch @tbkka fyi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend to do the inverse and keep the breaking change against main
and remove the one against the latest release. We do this in our other repos. This is really useful because sometimes the tool reports ABI but not API breaks which we force-merge over. If we compare against the release we have to force merge until we cut another release.
Sorry, already hit submit. Will follow up. So you don't bother with a known api breaks file then? |
Correct. We make the decision once in a PR where we have to merge over it and then consider it baseline again. |
Someone on the Apple side will have to do any configuration need to allow the force merge, I'm not sure if something needs to be tweaked in the project configuration on GitHub to allow that. |
main
now being used for releases, just need to check against the last release.