Undo breaking changes in SwiftProtobufPluginLibrary #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasvl
reviewed
Jun 25, 2024
thomasvl
reviewed
Jun 25, 2024
gjcairo
force-pushed
the
breaking-changes-plugin-lib
branch
from
80123a9 to
1ee2d1c
Compare
gjcairo
force-pushed
the
breaking-changes-plugin-lib
branch
from
1ee2d1c to
ac31b5c
Compare
thomasvl
approved these changes
Jun 26, 2024
FranzBusch
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we were undoing breaking changes in
mainto tag the next minor release, we forgot to check for breaking changes onSwiftProtobufPluginLibraryand only fixed those on theSwiftProtobuftarget.This PR undoes all breaking changes in
SwiftProtobufPluginLibrary. It mostly required re-adding removed properties (or undo renames) while still keeping the new ones, and deprecating the old ones.