Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update xcodeproj on 1.x branch #1593

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Update xcodeproj on 1.x branch #1593

merged 2 commits into from
Mar 25, 2024

Conversation

glbrntt
Copy link
Contributor

@glbrntt glbrntt commented Mar 25, 2024

Building with the xcodeproj fails because a number of files have been added/removed and these changes haven't been reflected in the xcodeproj. Additionally, the base config sets the macOS deployment target to 10.9, but this isn't valid as Data was made available in 10.10.

@glbrntt
Update xcodeproj
d3600a1 
Building with the xcodeproj fails because a number of files have been
added/removed and these changes haven't been reflected in the xcodeproj.
Additionally, the base config sets the macOS deployment target to 10.9,
but this isn't valid as `Data` was made available in 10.10.
@thomasvl
Copy link
Collaborator

Additionally, the base config sets the macOS deployment target to 10.9, but this isn't valid as Data was made available in 10.10.

Huh. Is Xcode complaining about this now? Wonder what it hasn't tripped things up before.

@thomasvl
Copy link
Collaborator

Additionally, the base config sets the macOS deployment target to 10.9, but this isn't valid as Data was made available in 10.10.

Huh. Is Xcode complaining about this now? Wonder what it hasn't tripped things up before.

The podspec says 10.11, might make sense to sync back up with that.

@glbrntt
Copy link
Contributor Author

glbrntt commented Mar 25, 2024

Additionally, the base config sets the macOS deployment target to 10.9, but this isn't valid as Data was made available in 10.10.

Huh. Is Xcode complaining about this now? Wonder what it hasn't tripped things up before.

It was on Xcode 15.3, I didn't try an older version. I was a little surprised it hadn't been seen before.

@thomasvl thomasvl changed the title Update xcodeproj Update xcodeproj on 1.x branch Mar 25, 2024
@thomasvl thomasvl merged commit 91746d5 into apple:1_x_release_branch Mar 25, 2024
19 checks passed
@glbrntt glbrntt deleted the update-xcodeproj branch March 25, 2024 17:52
@chenrui333 chenrui333 mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasvl thomasvl thomasvl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glbrntt @thomasvl