Pull the concurrency warnings fixes to the 1.x branch #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update AnyMessageStorage.swift - Update the generator.
|
I figured if we're likely to do a release soon we should pick these up as they impact generated code and thus could impact folks adopting the warnings in there own packages as the generated code will be compiled in those contexts. |
I think this is the rest of the issues in apple#1560 This is the different approach discussed in apple#1564.
thomasvl
force-pushed
the
concurrency_warnings_1_x
branch
from
281abb5 to
627d77b
Compare
Lukasa
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.