Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heap] Convert CFBinaryHeap benchmarks to C #67

Closed
lorentey opened this issue Aug 7, 2021 · 0 comments · Fixed by #76
Closed

[Heap] Convert CFBinaryHeap benchmarks to C #67

lorentey opened this issue Aug 7, 2021 · 0 comments · Fixed by #76
Assignees
Labels
enhancement New feature or request Heap Min-max heap module

Comments

@lorentey
Copy link
Member

lorentey commented Aug 7, 2021

The CFBinaryHeap reference benchmarks are currently defined as an Objective-C class. These microbenchmarks could be sensitive to ObjC messaging overhead (however small it is) -- it would make sense to convert them to a pure C interface instead, like we did with the existing std::deque etc benchmarks.

@lorentey lorentey added enhancement New feature or request Heap Min-max heap module labels Aug 7, 2021
@lorentey lorentey self-assigned this Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Heap Min-max heap module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant