Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix element timeout changing page object timeout issue #468

Merged
merged 1 commit into from
Sep 9, 2016
Merged

fix element timeout changing page object timeout issue #468

merged 1 commit into from
Sep 9, 2016

Conversation

truebit
Copy link
Contributor

@truebit truebit commented Sep 9, 2016

Change list

fix element timeout changing page object timeout issue

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

this bug fixes #467

@TikhomirovSergey TikhomirovSergey added this to the 5.0.0 milestone Sep 9, 2016
@TikhomirovSergey
Copy link
Contributor

TikhomirovSergey commented Sep 9, 2016 •
edited
Loading

Ok.
Please do not forget to add a test next time #469

@TikhomirovSergey TikhomirovSergey merged commit 31ce398 into appium:master Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug refactor
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

page object pattern, field with "@WithTimeout" would change the global implicit wait time
2 participants
@truebit @TikhomirovSergey