Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add accessible attribute to the xml tree in case of useJSONSource #2484

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix: Add accessible attribute to the xml tree in case of useJSONSource #2484

merged 2 commits into from
Oct 23, 2024

Conversation

swngarg-lt
Copy link
Contributor

@swngarg-lt swngarg-lt commented Oct 23, 2024 •
edited
Loading

  • With useJSONSource as false, source contains accessible attribute
  • With useJSONSource as true, it bypasses the attribute.

@swngarg-lt
Added accessible attribute to the xml tree in case of useJSONSource c…
8aa5645 
…apability

With useJSONSource as false, source contains accessible attribute but with useJSONSource as true, it bypasses this.
@swngarg-lt swngarg-lt changed the title Added accessible attribute to the xml tree in case of useJSONSource c… Add accessible attribute to the xml tree in case of useJSONSource c… Oct 23, 2024
@swngarg-lt swngarg-lt changed the title Add accessible attribute to the xml tree in case of useJSONSource c… feat: Add accessible attribute to the xml tree in case of useJSONSource c… Oct 23, 2024
@swngarg-lt swngarg-lt changed the title feat: Add accessible attribute to the xml tree in case of useJSONSource c… feat: Add accessible attribute to the xml tree in case of useJSONSource Oct 23, 2024
@swngarg-lt swngarg-lt changed the title feat: Add accessible attribute to the xml tree in case of useJSONSource fix: Add accessible attribute to the xml tree in case of useJSONSource Oct 23, 2024
@swngarg-lt
Copy link
Contributor Author

changed PR title from feat to fix

@KazuCocoa KazuCocoa merged commit e25ac81 into appium:master Oct 23, 2024
17 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
@semantic-release-bot
chore(release): 7.28.3 [skip ci]
d35ad54 
## [7.28.3](v7.28.2...v7.28.3) (2024-10-23)

### Bug Fixes

* Add accessible attribute to the xml tree in case of useJSONSource ([#2484](#2484)) ([e25ac81](e25ac81))
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 7.28.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KazuCocoa KazuCocoa added size:S contribution size: S size:XS contribution size: XS and removed size:S contribution size: S labels Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
released size:XS contribution size: XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swngarg-lt @KazuCocoa