Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add autoFillPasswords capability #1972

Merged
merged 6 commits into from
Sep 14, 2023
Merged

feat: add autoFillPasswords capability #1972

merged 6 commits into from
Sep 14, 2023

Conversation

rerorero
Copy link
Contributor

@rerorero rerorero commented Sep 8, 2023 •
edited
Loading

This PR adds autoFillPasswords capability that allows to switch AutoFill Passwords settings for a simulator.
Related PR: appium/appium-ios-simulator#378

Looks like prettier modifies a lot of lines in pre-commit hook. I guess it's due to this recent change?
https://prettier.io/docs/en/options.html#trailing-commas

Default value changed from es5 to all in v3.0.0

Should I keep current trailing comma rule by adding prettierc?

@rerorero rerorero marked this pull request as ready for review September 8, 2023 13:53
mykola-mokhnach
mykola-mokhnach reviewed Sep 8, 2023
View reviewed changes
lib/desired-caps.js Outdated Show resolved Hide resolved
mykola-mokhnach
mykola-mokhnach reviewed Sep 8, 2023
View reviewed changes
lib/driver.js Outdated Show resolved Hide resolved
@rerorero rerorero mentioned this pull request Sep 10, 2023
Merged
@mykola-mokhnach
Copy link
Contributor

would it be possible to rebase this PR?

@rerorero
Copy link
Contributor Author

rerorero commented Sep 11, 2023 •
edited
Loading

Looks like the the test I have added didn't pass in CI but the status is green 🤔 I will check it.
https://pipelinesghubeus2.actions.githubusercontent.com/gIP2FJHApXY0M4FInFE0NsrKdj6XQtvFvsowyqrKwMWjJ9ZUQ3/_apis/pipelines/1/runs/16402/signedlogcontent/2?urlExpires=2023-09-11T09%3A55%3A38.1987357Z&urlSigningMethod=HMACV1&urlSignature=sEf%2BEWVieBtPM56GjChrsnoIsg7s38loHqNMEZSX8Ic%3D

@rerorero
Copy link
Contributor Author

rerorero commented Sep 11, 2023 •
edited
Loading

but the status is green

Ah it's because of threshold. I'll try to fix my tests anyway.

mykola-mokhnach
mykola-mokhnach reviewed Sep 12, 2023
View reviewed changes
lib/driver.js Outdated Show resolved Hide resolved
mykola-mokhnach
mykola-mokhnach reviewed Sep 12, 2023
View reviewed changes
lib/driver.js Outdated Show resolved Hide resolved
mykola-mokhnach
mykola-mokhnach reviewed Sep 12, 2023
View reviewed changes
lib/driver.js Outdated Show resolved Hide resolved
@rerorero
Copy link
Contributor Author

Thanks, I made changes based on your comments, PTAL.

KazuCocoa
KazuCocoa approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mykola-mokhnach
mykola-mokhnach reviewed Sep 13, 2023
View reviewed changes
lib/driver.js Outdated Show resolved Hide resolved
@mykola-mokhnach mykola-mokhnach merged commit 85aaa7f into appium:master Sep 14, 2023
17 checks passed
@KazuCocoa
Copy link
Member

hm, auto release is not working. let me check

github-actions bot pushed a commit that referenced this pull request Sep 14, 2023
@semantic-release-bot
chore(release): 5.1.0 [skip ci]
081dffa 
## [5.1.0](v5.0.0...v5.1.0) (2023-09-14)

### Features

* add autoFillPasswords capability ([#1972](#1972)) ([85aaa7f](85aaa7f))
* dummy feat commit to run the auto release ([#1983](#1983)) ([5916712](5916712))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rerorero @mykola-mokhnach @KazuCocoa