fix: launchApp regression #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Mar 31, 2023
KazuCocoa
commented
Mar 31, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 31, 2023
## [4.21.2](v4.21.1...v4.21.2) (2023-03-31) ### Bug Fixes * launchApp regression ([#1540](#1540)) ([a66cb47](a66cb47))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of #1539
9b9e6fa#diff-b394cf1ec7843c77eb14478b73321d02c718f7f8123b5416b6d88181627ac690L190-L199 changed the launchApp behavior. The master one did not create a new session between appium/xcuitest and WDA, so after the launchApp method, no commands worked.
This PR brings removed launchApp behavior.
The launchApp method removed in this PR was ordinary existed in lib/driver.js, but it seems like nothing used the method in my git history confirmation.
response.currentApp.bundleIDwas broken, but has existed since XCUITest driver v2 at least. It means Appium 1.22.3 had the method as well, but no non-reference error occurred for bundleID. We should have removed the method, i guess#1534 and this are what I found as regression for now.