chore: Short circuit if the app under test crashes while checking for alerts #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
force-pushed
the
inv_state
branch
from
3999bbc
to
0d51af6
Compare
KazuCocoa
approved these changes
Feb 28, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
## [4.18.4](v4.18.3...v4.18.4) (2023-02-28) ### Miscellaneous Chores * Short circuit if the app under test crashes while checking for alerts ([#1510](#1510)) ([5684cdf](5684cdf))
|
🎉 This PR is included in version 4.18.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid xcuitest from waiting for too long if the app under test or Safari crashes while waiting for atom response. See https://dev.azure.com/AppiumCI/Appium%20CI/_build/results?buildId=24956&view=logs&j=66348596-d35e-5e67-f0f1-be5c1aa44784&t=71e9a390-e9eb-5265-011c-e30f520bcba6 for an example