Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add helpers to control bluetooth and nfc adapters #779

Merged
merged 1 commit into from
May 11, 2024

Conversation

mykola-mokhnach
Copy link
Contributor

No description provided.

@mykola-mokhnach mykola-mokhnach requested a review from KazuCocoa May 10, 2024 20:23
'mobile: bluetooth': {
command: 'mobileBluetooth',
params: {
optional: ['opts'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be required: ['action'] to follow the README's required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently the validation of execute method parameters in this driver does not really work (and never worked). Would you have time to fix it?

'mobile: nfc': {
command: 'mobileNfc',
params: {
optional: ['opts'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be required: ['action'] to follow the README's required?

@mykola-mokhnach mykola-mokhnach merged commit a9403ff into appium:master May 11, 2024
10 checks passed
@mykola-mokhnach mykola-mokhnach deleted the bn branch May 11, 2024 06:00
github-actions bot pushed a commit that referenced this pull request May 11, 2024
## [3.4.0](v3.3.0...v3.4.0) (2024-05-11)

### Features

* Add helpers to control bluetooth and nfc adapters ([#779](#779)) ([a9403ff](a9403ff))
Copy link

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants