Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chromedriver version comparison in the chromedriver download #587

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Mar 24, 2023

It seems like appium/appium-chromedriver#289 ? broke the chromedriver version comparison, which was fixed in appium/appium-chromedriver#291 . It caused appium/appium#18368

@KazuCocoa KazuCocoa changed the title fix: minBrowserVersion in SyncOption should be a number fix: chromedriver version comparison in the chromedriver downloading Mar 24, 2023
@KazuCocoa KazuCocoa merged commit 3aa3c84 into master Mar 24, 2023
@KazuCocoa KazuCocoa deleted the kazucocoa/bump-chromedriver branch March 24, 2023 16:30
@KazuCocoa KazuCocoa changed the title fix: chromedriver version comparison in the chromedriver downloading fix: chromedriver version comparison in the chromedriver download Mar 24, 2023
github-actions bot pushed a commit that referenced this pull request Mar 24, 2023
## [2.12.7](v2.12.6...v2.12.7) (2023-03-24)

### Bug Fixes

* chromedriver version comparison in the chromedriver download ([#587](#587)) ([3aa3c84](3aa3c84))
@github-actions
Copy link

🎉 This PR is included in version 2.12.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant