feat: add skipping app state check in terminateApp when the given timeout is zero #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
changed the title
This reverts commit b2df760.
|
mm, it seems like |
|
was something broken in the base driver recently @boneskull ? ^ |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This reverts commit 6c3c4fc.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
thanks, the latest tests passed |
|
@mykola-mokhnach can you take a look when you have a chance? |
README.md
Outdated
| by checking the app state to ensure if the app process is actually stopped. | ||
|
|
||
| The app state check can be skipped if the given timeout is lower or equal to zero since UIAutomator driver 2.9.0. | ||
| The skip helps when you want to terminate the app process but does not want to check the process |
There was a problem hiding this comment.
...but do not want to check the process existence because the app under test may, for example, restart it automatically.
mykola-mokhnach
approved these changes
Oct 18, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
# [2.9.0](v2.8.0...v2.9.0) (2022-10-19) ### Features * add skipping app state check in terminateApp when the given timeout is zero ([#554](#554)) ([913dc39](913dc39))
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will do the same thing in the espresso driver after this merge.