Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with URLs of the member profile pages #1220

Closed
birdofpreyru opened this issue Jul 7, 2017 · 3 comments
Closed

Issue with URLs of the member profile pages #1220

birdofpreyru opened this issue Jul 7, 2017 · 3 comments

Comments

@birdofpreyru
Copy link
Collaborator

As reported by a community member:

I tried to open a profile page of [[iwi]] or John Dethridge, but if I open it says "404".
John Dethridge: https://www.topcoder.com/members/John%20Dethridge
[[iwi]]: https://www.topcoder.com/members/[[iwi]]
Seems like user includes space, '[', ']', '(', ')' cannot open user page.

It looks to me, there are two problems: (1) username in the URL must be URL-encoded, (2) the user profile endpoint demands trailing /. These links work:
https://www.topcoder.com/members/John%20Dethridge/
https://www.topcoder.com/members/%5B%5Biwi%5D%5D/

The best fix will be to update the routing inside topcoder-app, so that it redirects to the proper profile pages even if the incoming link violates (1) and/or (2).

@ThomasKranitsas
Copy link
Collaborator

@birdofpreyru which branch should I use?

@birdofpreyru
Copy link
Collaborator Author

@ThomasKranitsas dev

@birdofpreyru birdofpreyru changed the title [$60] - Issue with URLs of the member profile pages Issue with URLs of the member profile pages Jul 10, 2017
@birdofpreyru
Copy link
Collaborator Author

Fixed by the commit 989654c
@ajefts Can I push it to prod? To do so, is it still enough just to merge the change into master, or should I also tag the change with a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants