Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats #68

Merged
merged 3 commits into from
Aug 26, 2016
Merged

Stats #68

merged 3 commits into from
Aug 26, 2016

Conversation

freignat91
Copy link
Contributor

@freignat91 freignat91 commented Aug 25, 2016

#12

Initial amp stat command implementation (based on proposal here).
Only cpu for now as decided

Not implemented

--time-unit
--status and --health (requires amp-agent/etcd)
current data (not historic)
Verification

$ amp stats --cpu --container --service-name=kafka --period 5m
Should display cpu metrics of all containers for the kafka service, for the last 5 miutes

$ amp stats --cpu --service --period 5m
Should display cpu metrics for all services, for the last 5 minutes

$ amp stats --cpu --node --period 5m
Should display cpu metrics for all nodes, for the last 5 minutes

$ amp stats --cpu --task --period 5m
Should display cpu metrics for all tasks, for the last 5 minutes

@subfuzion
Copy link
Contributor

@freignat91 and @chrisccoy I just rebased with master and force pushed. Make sure you perform the following steps on your local branch:

$ git fetch origin stats
$ git reset --hard origin/stats

@subfuzion
Copy link
Contributor

I just formatted the source and squashed commits. I'm going to go ahead and merge this even though it's a work in progress to make it easier to coordinate project-wide CLI restructuring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants