Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix default value for adminserveraddress #627

Merged
merged 1 commit into from
Jan 3, 2017
Merged

fix default value for adminserveraddress #627

merged 1 commit into from
Jan 3, 2017

Conversation

freignat91
Copy link
Contributor

add default value for adminServerAddress in config

Test:

  • make install
  • rm ~/.config/amp/amp.yaml
  • amp config Verbose true (for instance)
  • verify the adminServerAddress value is well: 127.0.0.1:31315

bquenin
bquenin approved these changes Jan 3, 2017
View reviewed changes
Copy link
Contributor

@bquenin bquenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bquenin bquenin merged commit c94bcc2 into master Jan 3, 2017
@bquenin bquenin deleted the fixe-adminserver-address branch January 3, 2017 15:18
@bquenin bquenin modified the milestone: 0.5.0 Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bquenin bquenin bquenin approved these changes

Assignees
No one assigned
Labels
area/cli kind/bug
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@freignat91 @bquenin