amp flags --version, -V function correctly #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neha-viswanathan
changed the title
ndegory
suggested changes
Dec 15, 2016
| @@ -87,7 +87,7 @@ func (s *ampManager) init(firstMessage string) error { | |||
| defaultHeaders := map[string]string{"User-Agent": "amplifier"} | |||
| cli, err := client.NewClient(DockerURL, DockerVersion, nil, defaultHeaders) | |||
| if err != nil { | |||
| return fmt.Errorf("impossible to connect to Docker on: %s\n%v", DockerURL, err) | |||
| return fmt.Errorf("Impossible to connect to Docker on: %s\n%v", DockerURL, err) | |||
There was a problem hiding this comment.
Error message should not be capitalized. A PR is waiting to be merged with same kind of warnings: #545
| @@ -94,7 +94,7 @@ func RegistryPush(amp *client.AMP, cmd *cobra.Command, args []string) error { | |||
| return fmt.Errorf("Error parsing reference: %q is not a valid repository/tag", image) | |||
| } | |||
| if _, isCanonical := distributionRef.(distreference.Canonical); isCanonical { | |||
| return errors.New("refusing to create a tag with a digest reference") | |||
| return errors.New("Refusing to create a tag with a digest reference") | |||
| @@ -27,11 +27,11 @@ func init() { | |||
|
|
|||
| func createTopic(amp *client.AMP, cmd *cobra.Command, args []string) error { | |||
| if len(args) == 0 { | |||
| return errors.New("must specify topic name") | |||
| return errors.New("Must specify topic name") | |||
| } | ||
| name := args[0] | ||
| if name == "" { | ||
| return errors.New("must specify topic name") | ||
| return errors.New("Must specify topic name") |
subfuzion
suggested changes
Dec 15, 2016
There was a problem hiding this comment.
@neha-viswanathan I agree with @ndegory. Looks good overall. Please make the requested changes and also resolve merge conflicts. Thanks.
neha-viswanathan
force-pushed
the
amp-version
branch
from
bdc1a36
to
f2e9463
Compare
|
@ndegory I will add the Cobra Description to the root command as a different PR. |
ndegory
approved these changes
Dec 16, 2016
subfuzion
approved these changes
Dec 16, 2016
|
@neha-viswanathan there's an issue with this PR (already merged), previous commits (at least a part of #592) have been reverted. I noticed it with the output of |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issues #547 #561 #565
amp --version,amp -Vto only display amp versionTo test #547