Dockerizing integration tests

[bquenin]

Related to #410

Dockerizing integration tests.

Verification

$ make install
$ amp pf stop
$ amp pf pull
$ amp pf start
$ make test

[generalhenry]

This trick only works in a single node setup. Which is likely fine for now. docker 1.13 will be adding support for docker run within swarm overlay networks which would solve the issue.

[bquenin]

Yes you're right. I thought about this as an issue.
I didn't know that docker 1.13 will add this feature, but it will definitely solve the issue.
Maybe we should open an issue to keep track of it.

[ndegory]

why don't you use docker service ps amp-integration ? That would not be limited to the local node. You won't get the logs but at least you can loop on it to wait for the exited status.
Another trick would be to force the node on which you execute the task, with a constraint.

[bquenin]

@ndegory docker service ps amp-integration-test returns the task id, and I need the container id to get the logs. Here is how it works currently:

• starts the amp-integration-test service
• get the container id
• docker logs -f $CONTAINER_ID to get the output of the tests, which is cool because it's blocking and exits when the container exits.
• get the exit code of the container and exit with this code in the Makefile to report the test exit status

Hopefully, it's clearer with the explanation.

[ndegory]

@bquenin if you need the log then the only solution is to use the constraint:

nodeId=$(docker node ls  | grep '*' | awk '{print $1}')
docker service create --constraint "node.id == $nodeId" --network amp-infra --name amp-integration-test --restart-condition none appcelerator/amp-integration-test

[bquenin]

You're right, I'll add a node constraint.

[generalhenry]

Looks great, no troubles running it locally. I needs a write up of the changes for the change log, and the docs need to be updated to reflect it (there are references to localhost: in the docs)

[JosephGJ]

You need to get the latest changes and rebase to the master. Other than the small comments, this looks really good.

[JosephGJ]

This is slightly misleading. Even when the test runs correctly, it returns an error.

Error response from daemon: service amp-integration-test not found

[bquenin]

Yeah, I'll change the output message

[bquenin]

@JosephGJ I rebased on the master

[freignat91]

LGTM