Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update doc with new amp commands #473

Merged
merged 1 commit into from
Nov 21, 2016
Merged

update doc with new amp commands #473

merged 1 commit into from
Nov 21, 2016

Conversation

freignat91
Copy link
Contributor

@freignat91 freignat91 commented Nov 17, 2016 •
edited
Loading

related to #470

Update documentation with new amp commands usages and options

@generalhenry
Copy link
Contributor

There's also a reference in https://github.com/appcelerator/amp/tree/master/examples

@ndegory ndegory added this to the 0.4.0 milestone Nov 18, 2016
@freignat91
Copy link
Contributor Author

Example doc updated

bquenin
bquenin reviewed Nov 18, 2016
View reviewed changes
Copy link
Contributor

@bquenin bquenin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also mention that the swarm needs to be created beforehand (with docker swarm init for instance, or amp-swarm-deploy)

bquenin
bquenin approved these changes Nov 21, 2016
View reviewed changes
Copy link
Contributor

@bquenin bquenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bquenin bquenin merged commit 71ed8de into master Nov 21, 2016
@bquenin bquenin deleted the amp-doc branch November 21, 2016 10:11
bquenin pushed a commit that referenced this pull request Nov 21, 2016
@freignat91
update doc with new amp commands (#473)
f90afbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bquenin bquenin bquenin approved these changes

Assignees
No one assigned
Labels
area/docs
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@freignat91 @generalhenry @bquenin @ndegory