Refactor CLI tests #386
Merged
Refactor CLI tests #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freignat91
approved these changes
Oct 26, 2016
JosephGJ
reviewed
Oct 26, 2016
| for _, cmdSpec := range commandMap { | ||
| cmdString := generateCmdString(cmdSpec) | ||
| t.Log(cmdString, "Command passed.") | ||
| for i := 0; i < 10; i++ { |
There was a problem hiding this comment.
Originally used a small loop to iterate over the command 10 times. The service create command does not block until the service is built in the swarm.
Tests are currently failing due to this.
--- FAIL: TestCmds (0.22s)
cli_test.go:46: -----------------------------------------------------------------------------------------
cli_test.go:47: Running spec: test_samples/logs-all.yml
cli_test.go:97: Running: amp logs
cli_test.go:46: -----------------------------------------------------------------------------------------
cli_test.go:47: Running spec: test_samples/logs-metadata.yml
cli_test.go:97: Running: amp logs -m
cli_test.go:46: -----------------------------------------------------------------------------------------
cli_test.go:47: Running spec: test_samples/logs-numbered.yml
cli_test.go:97: Running: amp logs -n 10
cli_test.go:46: -----------------------------------------------------------------------------------------
cli_test.go:47: Running spec: test_samples/logs-stack.yml
cli_test.go:97: Running: amp logs --stack stack1
cli_test.go:46: -----------------------------------------------------------------------------------------
cli_test.go:47: Running spec: test_samples/service-create.yml
cli_test.go:97: Running: amp service create appcelerator/pinger --name pinger -p www:90:3000
cli_test.go:46: -----------------------------------------------------------------------------------------
cli_test.go:47: Running spec: test_samples/service-curl.yml
cli_test.go:97: Running: curl localhost:90/ping
cli_test.go:49: miss matched expected output: % Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (7) Failed to connect to localhost port 90: Connection refused
FAIL
exit status 1
FAIL github.com/appcelerator/amp/cmd/amp/cli 0.813s
There was a problem hiding this comment.
Testing a service creation should probably be in a single test spec (not 2 as it is today), and waiting for the service to be up, included in this test spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #370
Note that the tests are not working as they were not working already. I just made some changes to be able to fix them in a subsequent PR.
Verification