Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest release of NATS streaming on master #372

Merged
merged 2 commits into from
Oct 25, 2016
Merged

Use latest release of NATS streaming on master #372

merged 2 commits into from
Oct 25, 2016

Conversation

bquenin
Copy link
Contributor

@bquenin bquenin commented Oct 24, 2016

Related to #318

Verification

$ ./swarm pull
$ ./swarm start
$ make test

@subfuzion
Copy link
Contributor

@bquenin Based on our experience, I think we're better off using explicit versions even on the master branch for deterministic behavior. I know that we want to track their development as closely as possible for the clustering features, but I would prefer that we update explicitly to 0.3.0 and that all version bumps go through the PR/test process.

@bquenin bquenin changed the title Use latest version of NATS streaming on master Use latest release of NATS streaming on master Oct 25, 2016
@bquenin
Copy link
Contributor Author

bquenin commented Oct 25, 2016

@subfuzion sure. I changed it to the 0.3.0 release instead of latest.

subfuzion
subfuzion approved these changes Oct 25, 2016
View reviewed changes
Copy link
Contributor

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@subfuzion subfuzion merged commit 1aaeef0 into master Oct 25, 2016
@subfuzion subfuzion deleted the nats-latest branch October 25, 2016 12:03
@subfuzion subfuzion added this to the 0.2.1 milestone Oct 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subfuzion subfuzion subfuzion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@bquenin @subfuzion