Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding topic create, list and remove #366

Merged
merged 1 commit into from
Oct 21, 2016
Merged

Adding topic create, list and remove #366

merged 1 commit into from
Oct 21, 2016

Conversation

bquenin
Copy link
Contributor

@bquenin bquenin commented Oct 21, 2016

Related to #288

Verification

$ ./swarm pull
$ ./swarm start
$ make test

Verification (CLI)

$ make install
$ amplifier &
$ amp topic ls
ID   Name   

$ amp topic create test1
2106e15a3b1d132abcc6899f7ee7044235a73304f9770510ee2c396e609bbb3d

$ amp topic create test1
2016/10/21 14:41:03 Failed to create topic: rpc error: code = 2 desc = Topic already exists: test1

$ amp topic create test2
11b11b55a457705e62ee678c681676316271e70cb5b9d25d8a781dbe17f82547

$ amp topic create test2
2016/10/21 14:41:08 Failed to create topic: rpc error: code = 2 desc = Topic already exists: test2

$ amp topic ls
ID                                                                 Name    
11b11b55a457705e62ee678c681676316271e70cb5b9d25d8a781dbe17f82547   test2   
2106e15a3b1d132abcc6899f7ee7044235a73304f9770510ee2c396e609bbb3d   test1   

$ amp topic rm 11b11b55a457705e62ee678c681676316271e70cb5b9d25d8a781dbe17f82547
11b11b55a457705e62ee678c681676316271e70cb5b9d25d8a781dbe17f82547

$ amp topic ls
ID                                                                 Name    
2106e15a3b1d132abcc6899f7ee7044235a73304f9770510ee2c396e609bbb3d   test1   

$ amp topic rm 2106e15a3b1d132abcc6899f7ee7044235a73304f9770510ee2c396e609bbb3d
2106e15a3b1d132abcc6899f7ee7044235a73304f9770510ee2c396e609bbb3d

$ amp topic ls
ID   Name   

$ amp topic rm 2106e15a3b1d132abcc6899f7ee7044235a73304f9770510ee2c396e609bbb3d
2016/10/21 14:41:14 Failed to remove topic: rpc error: code = 2 desc = Topic not found: 2106e15a3b1d132abcc6899f7ee7044235a73304f9770510ee2c396e609bbb3d

Copy link
Contributor

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Please chat with @JosephGJ and @neha-viswanathan next week about getting the CLI test suite updated for this based on the test features that just landed here.

@subfuzion subfuzion merged commit c249b3e into master Oct 21, 2016
@subfuzion subfuzion deleted the topics branch October 21, 2016 22:45
@subfuzion subfuzion added this to the 0.2.1 milestone Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants