Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add telegraf service and grafana dashboard for haproxy stats #315

Merged
merged 1 commit into from
Oct 18, 2016

Conversation

ndegory
Copy link
Contributor

@ndegory ndegory commented Oct 14, 2016

Warning: appcelerator-archive/docker-haproxy#2 (stats listener updates for haproxy:1.0.1) should be merged before this one.

  • new telegraf-haproxy service, gathering stats from the haproxy service
  • new Grafana dashboard for Haproxy stats

How to test:
$ swarm pull
$ swarm start
$ swarm monitor
once all services are up, connect to grafana (localhost:6001), authenticate with the admin login, and check the Load Balancer dashboard, data should be displayed.

Copy link
Contributor

@generalhenry generalhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

Copy link
Contributor

@freignat91 freignat91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
HAProxy is up to date on its branch 1.0.1 included stats listener updates

@subfuzion
Copy link
Contributor

@ndegory Please rebase against master since we've made other swarm dependency changes (eg, zookeeper+kafka -> nats). Thanks!

Copy link
Contributor

@freignat91 freignat91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndegory
Copy link
Contributor Author

ndegory commented Oct 18, 2016

was rebased, but tests are still failing. My tests are also failing on the master branch, so I can't confirm or disprove tests on this branch.

@subfuzion
Copy link
Contributor

👍

@subfuzion subfuzion merged commit 17d997b into master Oct 18, 2016
@subfuzion subfuzion deleted the haproxy-telemetry branch October 18, 2016 16:45
@subfuzion subfuzion added this to the 0.2.0 milestone Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants