Creating ~/registry/data folder in order to avoid log flooding #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LNGTM |
|
the registry service is now using a named volume (#281), so no need of a mount point on the host |
|
Ok, reverting with #286 |
|
@bertrand-quenin @ndegory @freignat91 The title of this PR alone is not a good enough explanation of the problem nor why creating a directory helps. This is a good example of the kind of PR "rubber stamping" we want to avoid. We want to ensure that PRs will make sense to anyone else reviewing them. |
subfuzion
added
version/0.1
and removed
version/0.1
area/cli
area/logging
area/networking
area/service
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification
Verify that the
~/registry/datafolder is created.