-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service rm #253
Service rm #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ok
} | ||
|
||
message RemoveRequest { | ||
string ident = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ident instead of id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making it clear it can be an ID, short ID, or name. Actually, that was something that @freignat91 recommended. I have no problem calling it id
, which matches docker docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine, it could use a comment to make that clear.
follow up: should RemoveResponse return an ident instead of an id?
Looks good, needs rebase |
9b18fb9
to
489dbe0
Compare
Closes #252
Verification
Merge #251 first.