Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logs by stack #242

Merged
merged 1 commit into from
Sep 24, 2016
Merged

Adding logs by stack #242

merged 1 commit into from
Sep 24, 2016

Conversation

bquenin
Copy link
Contributor

@bquenin bquenin commented Sep 24, 2016

Close #232

Verification

$ sudo ./swarm start
$ make
$ make test
$ ./amplifier

In another terminal:

$ ./amp stack up stack -f api/rpc/stack/test_samples/sample-04.yml
$ ./amp logs --stack stack

Copy link
Contributor

@freignat91 freignat91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok

@freignat91 freignat91 merged commit 340ff41 into master Sep 24, 2016
@subfuzion
Copy link
Contributor

subfuzion commented Sep 25, 2016

@bertrand-quenin @freignat91 Some log tests are failing:

--- FAIL: TestShouldFilterByService (0.04s)
        Error Trace:    logs_test.go:120
        Error:          Should NOT be empty, but was []
        Messages:       We should have at least one entry

--- FAIL: TestShouldFilterByMessage (0.01s)
        Error Trace:    logs_test.go:131
        Error:          Should NOT be empty, but was []
        Messages:       We should have at least one entry

--- FAIL: TestShouldFetchGivenNumberOfEntries (0.22s)
        Error Trace:    logs_test.go:154
        Error:          Not equal: 111 (expected)
                                != 110 (actual)

        Error Trace:    logs_test.go:154
        Error:          Not equal: 121 (expected)
                                != 110 (actual)

        Error Trace:    logs_test.go:154
        Error:          Not equal: 131 (expected)
                                != 110 (actual)

        Error Trace:    logs_test.go:154
        Error:          Not equal: 141 (expected)
                                != 110 (actual)

        Error Trace:    logs_test.go:154
        Error:          Not equal: 151 (expected)
                                != 111 (actual)

        Error Trace:    logs_test.go:154
        Error:          Not equal: 161 (expected)
                                != 111 (actual)

        Error Trace:    logs_test.go:154
        Error:          Not equal: 171 (expected)
                                != 111 (actual)

        Error Trace:    logs_test.go:154
        Error:          Not equal: 181 (expected)
                                != 111 (actual)

        Error Trace:    logs_test.go:154
        Error:          Not equal: 191 (expected)
                                != 111 (actual)

FAIL
FAIL    github.com/appcelerator/amp/api/rpc/logs        11.540s
make: *** [test] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants