Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import command doesn't throw error for invalid json #175

Open
lakhansamani opened this issue Aug 29, 2019 · 0 comments
Open

import command doesn't throw error for invalid json #175

lakhansamani opened this issue Aug 29, 2019 · 0 comments

Comments

@lakhansamani
Copy link
Contributor

Currently, abc doesn't throw an error when we have an invalid JSON file, rather it succeeds with 0 records inserted.

How to replicate

  • Create an invalid JSON file. Here file has extra ,
echo '[
  {
    "name": "jame",
    "email": "[email protected]",
  }
]' > test1.json
  • Try abc command
    abc import --src_type=json --src_uri=test1.json --log.level=debug http://admin:admin@localhost:9200/test

  • abc version used here: 1.0.0 Preview Release 2

Expected output

Command should throw an error with correct exit status, if the command fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant