Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gzipme module is of low quality, does not catch errors at all (throws hard exception and bombs app) #33

Open
boutell opened this issue Apr 18, 2018 · 1 comment

Comments

@boutell
Copy link
Member

boutell commented Apr 18, 2018

We will need to remove this in favor of using gzip streams properly, no npm dependency needed, although we could simplify it to a gzipme.js of our own with the same API plus a useful callback that implements error reporting.

  var out = zlib.createGzip();
  fileOut = fs.createWriteStream(filename);
  out.pipe(fileOut);
  // listening for both finish and errors properly, pipe aread stream into out
@boutell
Copy link
Member Author

boutell commented Apr 18, 2018

This is a blocker for releasing azure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants