Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm to version 7.7.5 if needed #77

Closed
apolopena opened this issue Mar 27, 2021 · 1 comment
Closed

Update npm to version 7.7.5 if needed #77

apolopena opened this issue Mar 27, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main

Comments

@apolopena
Copy link
Owner

Problem this feature will solve

This will allow #76 to be fixed.

Background

At the time of wirting this. the Gitpod platform was using npm version 6.14.11

Proposed Solution

Update npm if its current version is less than 7.7.5
Just use a spinner and update the status to Done or Failed depending of success or failure.

Constraints and Assumptions

Laravel scripts use npm
Add an API to utils.sh that can compare two version numbers that use the pattern:

  • <any # of digits>.<any # of digits>.<any # of digits>

Alternatives or Workarounds

Deal with hard to track down npm errors.

Additional context

It is debatable if npm should always be updated to the latest version. I decided to just pick a known stable version and leave it there.
It definately makes it more futureproof to update to the latest version but also it could make it less stable.

@apolopena apolopena added the enhancement New feature or request label Mar 27, 2021
@apolopena apolopena self-assigned this Mar 27, 2021
@apolopena
Copy link
Owner Author

An API to compare version number has been added to utils.sh
See the function named: comp_ver_lt

apolopena added a commit that referenced this issue Mar 27, 2021
@apolopena apolopena added the passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main label Mar 29, 2021
@apolopena apolopena changed the title Update npm to version 7.7.5 Update npm to version 7.7.5 if needed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Projects
None yet
Development

No branches or pull requests

1 participant