Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not open preview until the entire init sequence has completed #44

Closed
apolopena opened this issue Mar 3, 2021 · 0 comments
Closed

Do not open preview until the entire init sequence has completed #44

apolopena opened this issue Mar 3, 2021 · 0 comments
Assignees
@apolopena
Labels
bug Something isn't working passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main

Comments

@apolopena
Copy link
Owner

Describe the bug

During a first run of a workspace the preview browser is opened way before the system is ready to display any content

Steps to reproduce

  1. Create a new workspace from this repo using Theia as your editor. In starter.ini, ensure a front end scaffolding like react is used.
    The preview browser opens and refreshes while project scaffolding is still being set up

Expected behavior

The preview browser should open only after all code in the init command has finished.

Additional information
@apolopena apolopena added the bug Something isn't working label Mar 3, 2021
@apolopena apolopena self-assigned this Mar 3, 2021
apolopena added a commit that referenced this issue Mar 4, 2021
@apolopena
🐛 FIX: splice in changes from https://github.com/apolopena/q-and-a-ch…
b892185 
…allenge/pull/3\#issue-584276771: #40 #42 #44 #47 #48 #49
apolopena added a commit that referenced this issue Mar 5, 2021
@apolopena
Added missing code from b892185
3bf6949 
dev qa fix for #44
@apolopena apolopena added passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main and removed in-dev-qa labels Mar 5, 2021
@apolopena apolopena mentioned this issue Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apolopena apolopena

Labels
bug Something isn't working passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apolopena