Missing and overwritten scaffolding files when scaffolding is already in VCS

[apolopena]

Describe the bug

After project scaffolding is saved to the repo during the first workspace image build, subsequent rebuilds of the workspace image which may contain new scaffolding such as phpmyadmin, do not copy over. Also project scaffolding is created and copied over blindly even if it already exists which results in data loss.

Screenshots

Steps to reproduce

For the no vendor folder problem

1. Create a fresh workspace of this repo
2. Save project scaffolding to the repo
3. Create a fresh workspace from the repo
4. Force a rebuild of the workspace by incrementing the value for INVALIDATE_CACHE in .gitpod.Dockerfile

The vendor folder is no longer present and the project will not run.

For the existing front end scaffolding gets overwritten problem

1. Create a fresh workspace of this repo, ensure no front end scaffolding is installed by default (see starter.ini)
2. Save project scaffolding to the repo
3. Modify starter.ini to install react
4. save files to repo
5. Create a fresh workspace with the repo
6. Add a comment to resources/js/app.js (this content of the comment arbitrary)
7. Save files to the repo
8. Create a fresh workspace from the repo

The comment in `resources/js/app.js will be gone.

Expected behavior

Any new files created in the project scaffolding phase via .gitpod.Dockerfile such as the vendor folder or public/phpmyadmin should be copied over only if they do not already exist. Furthermore any scaffolding created during the init phase such as scaffolding created directly in the project folder (i.e react) should only be copied over if that scaffolding does not already exist in version control.

Additional information

Switch from mv to rsync so that all new files and directories will be copied over from ~/test-app

• Hook to determine if laravel/ui has already been installed: composer show | grep laravel/ui >/dev/null && __ui=1 || __ui=0
• Hook to determine if a node package such as react already exists. Use this for detecting existing frontend scaffolding already in version control.

node_package_exists () {
  [ -z $2 ] && local path='node_modules' || local path="$2/node_modules"
  ls "$path" 2>/dev/null | grep -w $1 >/dev/null 2>&1 && echo "1" || echo "0"
}

[apolopena]

No dev-qa for vue was performed. It should be fine, if not it will be addressed if the issue arises.