Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration options for out of the box .editorconfig #34

Closed
apolopena opened this issue Feb 9, 2021 · 0 comments
Closed

configuration options for out of the box .editorconfig #34

apolopena opened this issue Feb 9, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main

Comments

@apolopena
Copy link
Owner

Problem this feature will solve

Laravel forces 4 space indents in all files (PSR2). Javascript and other developers often want 2 spaces as the default and 4 spaces in *php files to conform to PSR2 or PSR12 standards. If a developer is not saavy on the .editorconfig system, they may wonder why some of their editor project settings (such as tabSize) are not being respsected.

Background

Laravel is opinionated, it writes in a .editorconfig. Sometimes developers need more flexibility.

Proposed Solution

Add a configuration in starter.ini to leave the Laravel default .editorconfig alone, use a pre-built .editorconfig that stick to PSR2/12 standards for all files but only php files use an indent of 4 spaces., or give the option to use not .editorconfig file at all (delete it).

Constraints and Assumptions

# valid values are:
# laravel-default: use the .editorconfig that comes with the laravel project scaffolding
# laravel-js-2space: altered vesrion of laravel-default allowing for 2 space indents for most files. 
#     --> see: bash/snippets/editorconfig/laravel-js-2space
# none: delete .editorconfig. Do not enforce project wide editor settings.
# Note: if left blank or set to an invalid value, laravel-default will be used

Alternatives or Workarounds

This feature is only for developers that dont want to think about granular configuration of project wide editor formats.

@apolopena apolopena added the enhancement New feature or request label Feb 9, 2021
apolopena added a commit that referenced this issue Feb 9, 2021
apolopena added a commit that referenced this issue Feb 9, 2021
apolopena added a commit that referenced this issue Feb 9, 2021
@apolopena apolopena self-assigned this Feb 9, 2021
@apolopena apolopena added the passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main label Feb 9, 2021
@apolopena apolopena mentioned this issue Feb 9, 2021
apolopena added a commit that referenced this issue Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Projects
None yet
Development

No branches or pull requests

1 participant