Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove query parameter from the url for debug-on and debug-off #17

Closed
apolopena opened this issue Feb 1, 2021 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request gitpod-config Related to gitpod configuration (bash scripts etc...) passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main

Comments

@apolopena
Copy link
Owner

apolopena commented Feb 1, 2021

Problem this feature will solve

The query parameter used to trigger debugging gets in the way for a number of reasons.

Background

Proposed Solution

Remove the query parameter after toggling debugger functionality.
Allow for either the query param to show or for it to be removed from the url.

Constraints and Assumptions

Give the nature of the gp binary, this will need to be a double refresh which might be a little clunky, it will need to be tested out a bit to ensure its a good user experience

Alternatives or Workarounds

  1. Open an external preview browser.
  2. Remove the query parameter from the URL.

Additional context

Add any other context or screenshots about the feature request here.

@apolopena apolopena added enhancement New feature or request gitpod-config Related to gitpod configuration (bash scripts etc...) labels Feb 1, 2021
@apolopena
Copy link
Owner Author

Fixed in #15

@apolopena apolopena added the passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main label Feb 2, 2021
apolopena added a commit that referenced this issue Feb 2, 2021
@apolopena apolopena self-assigned this Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gitpod-config Related to gitpod configuration (bash scripts etc...) passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Projects
None yet
Development

No branches or pull requests

1 participant