Question about Database Migration

[strausmann]

Why is a database migration not automatically performed at the end? Is there a reason why this does not happen in the standard?

gitpod-laravel-starter/.gp/bash/init-project.sh

Lines 10 to 23 in acf39fe

	# BEGIN example code block - migrate database
	# . .gp/bash/spinner.sh # COMMENT: Load spinner
	# __migrate_msg="Migrating database"
	# log_silent "$__migrate_msg" && start_spinner "$__migrate_msg"
	# php artisan migrate
	# err_code=$?
	# if [ $err_code != 0 ]; then
	# stop_spinner $err_code
	# log -e "ERROR: Failed to migrate database"
	# else
	# stop_spinner $err_code
	# log "SUCCESS: migrated database"
	# fi
	# END example code block - migrate database

[apolopena]

By default when a starter is created there is nothing to migrate right? Also if a user uses a preset in the workspace URL then migrations will happen there and so we dont want to do redundant migrations.

I figure that once a user has something to migrate they will enable it themselves but now that you mention it I do see that that is one extra step they wouldnt have to do. Thoughts?

[strausmann]

That was exactly my thought too. Of course, a new project does not need a direct migration. However, there is no indication in the documentation that the migration has already been prepared in the init project, but is still waiting to be activated.

[apolopena]

I will add a migration section to the README and talk about typical Laravel migration and seeding setups using .gp/bash/init-project.sh such as what is used in some of the presets (example projects) such as:
https://gitpod.io/#EXAMPLE=1/https://github.com/apolopena/gitpod-laravel-starter
that uses
https://github.com/apolopena/qna-demo-skeleton/blob/main/.gp/bash/init-project.sh

[apolopena]

Moved to #183