Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Fix forceFetch on SSR #293

Merged
merged 3 commits into from
Oct 28, 2016
Merged

Fix forceFetch on SSR #293

merged 3 commits into from
Oct 28, 2016

Conversation

jbaxleyiii
Copy link
Contributor

@jbaxleyiii jbaxleyiii commented Oct 28, 2016

Fix for #292

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

@jbaxleyiii jbaxleyiii merged commit 71bad83 into master Oct 28, 2016
@jbaxleyiii jbaxleyiii deleted the 292 branch October 28, 2016 17:02
@tmeasday
Copy link
Contributor

tmeasday commented Nov 1, 2016

Interesting. We added a ssrMode: true to AC which simply ignores forceFetch to get around this problem originally.

I don't recall if we had an idea at the time of use cases where people might validly want to force fetch in SSR (and thus not set the option). Probably not huh? If so, we should remove ssrMode as an option to AC (and make sure the angular SSR works the same way).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants