Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary print and subsequent parse #678

Merged
merged 3 commits into from
Mar 16, 2018
Merged

Remove unnecessary print and subsequent parse #678

merged 3 commits into from
Mar 16, 2018

Conversation

mfix22
Copy link
Contributor

@mfix22 mfix22 commented Mar 14, 2018 •
edited
Loading

This PR removes an unnecessary print/parse pair that is used for making remote schema fetches 😄

Let me know if you want me to do anything different.

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

@mfix22
Copy link
Contributor Author

mfix22 commented Mar 14, 2018

Line coverage dropped because lines were deleted 😄

@freiksenet
Copy link
Contributor

Thanks!

@freiksenet freiksenet merged commit c91e577 into ardatan:master Mar 16, 2018
This was referenced Mar 19, 2018
Closed
Closed
Merged
Closed
@renovate renovate bot mentioned this pull request Mar 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfix22 @freiksenet