Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have just spent a couple of hours trying to get deprecation directives (among other things) working in
graphql-server
. The last of these issues had me wondering why graphql/graphiql#273 was closed but seemingly not working/implemented, even after upgrading to the latest package versions of graphql-server, graphiql, graphql-tools etc.The issue is that the locally installed GraphQL implementation is not used at all and
graphql-server
seems to do its own dependency management instead.Is it possible to just
import 'graphiql'
? and addgraphiql
as a peer dependency tographql-server
? What edge cases was the current implementation intending to fix?In the meantime, is it reasonable to just upgrade the GraphiQL version like this? There appear to have been efforts to make GraphiQL versions backwards compatible, but I'm far from an expert on it.