Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'literal' option to env #36

Merged
merged 5 commits into from
Dec 14, 2016
Merged

Conversation

jtmthf
Copy link
Contributor

@jtmthf jtmthf commented Dec 13, 2016

From #35

Just use env: 'literal' to use literal grapnel files with either .graphql or .gql as an extension. No need to modify tagName.

Also added yarn lock.

@stubailo
Copy link
Contributor

Also added yarn lock.

I don't think we want a yarn lock file in a library - consistent builds are actually a disadvantage when testing an npm package since people who install it are always going to get the newest versions of dependencies. Can you remove it please?

Also, can we add documentation about this new env to the README?

@jtmthf
Copy link
Contributor Author

jtmthf commented Dec 13, 2016

Yeah I can go ahead and do that. For docs, in addition to configuring the .eslintrc.js file, what about editor integration? I haven't tested in Atom yet, but it's eslint plugin should work fine after making a change to the settings. For VSCode, I had to use a beta version of the eslint extension, make a configuration change, and install a graphql extension to work.

@stubailo
Copy link
Contributor

Oh I was just thinking about documenting the new env you added. We could definitely use better documentation about how to set up editor integration for .graphql files, but that should be a separate PR I think.

@stubailo
Copy link
Contributor

@jtmthf ah, one last thing sorry - can you add to the changelog so I can publish a new version? This looks great now.

@jtmthf
Copy link
Contributor Author

jtmthf commented Dec 13, 2016

@stubailo Should I mark it as v0.4.1?

@stubailo
Copy link
Contributor

Just putting it under vNEXT is fine - I'll change that to the next version after merging. Just asking you to write the change description.

@stubailo stubailo merged commit 5e29092 into apollographql:master Dec 14, 2016
@stubailo
Copy link
Contributor

Published in 0.4.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants