-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'literal' option to env #36
Conversation
I don't think we want a yarn lock file in a library - consistent builds are actually a disadvantage when testing an npm package since people who install it are always going to get the newest versions of dependencies. Can you remove it please? Also, can we add documentation about this new env to the README? |
Yeah I can go ahead and do that. For docs, in addition to configuring the .eslintrc.js file, what about editor integration? I haven't tested in Atom yet, but it's eslint plugin should work fine after making a change to the settings. For VSCode, I had to use a beta version of the eslint extension, make a configuration change, and install a graphql extension to work. |
Oh I was just thinking about documenting the new env you added. We could definitely use better documentation about how to set up editor integration for |
@jtmthf ah, one last thing sorry - can you add to the changelog so I can publish a new version? This looks great now. |
@stubailo Should I mark it as v0.4.1? |
Just putting it under |
Published in 0.4.2! |
From #35
Just use
env: 'literal'
to use literal grapnel files with either.graphql
or.gql
as an extension. No need to modifytagName
.Also added yarn lock.