docs: remove note on unsupported Alpine command #1248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the README called out the lack of support for the supergraph command in Rover for Alpine (due to the musl libs) Based on the mentioned issue[0] and merged PR[1] explaining the support for Alpine Linux and the introduction of a musl build matrix entry, it appears this is now supported. 0: #537 1: #538
|
@tcarrio: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
Unfortunately it seems I misunderstood the the docs in that PR- |
|
yup! unfortunately it's still accurate. if deno ever publishes musl binaries (or if we rewrite federation utilities in rust) we'll add support for it but until then you'll have to link against glibc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the README called out the lack of support for the supergraph command in Rover for Alpine (due to the musl libs)
Based on the mentioned issue and merged PR explaining the support for Alpine Linux and the introduction of a musl build matrix entry, it appears this is now supported.