-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set $VERSION statically in curl installer #88
Comments
@jbaxleyiii had this idea which would work just fine |
This should mostly be supported already via spaceport.
The benefit here is we have edge caching and usage analtyics already built in https://github.com/apollographql/spaceport/blob/main/src/routes/cli.ts#L40-L51 and the CLI / shell scripts can be much simpler. |
After looking at this, it feels weird to me that an install script (which itself is versioned and released with versioned tags) would be responsible for downloading/installing any version of Rover. I think it makes more sense to have the script be static, and use another source, like spaceport, to point at the right script. So |
right now it's required to have a $VERSION variable set before the curl installer works. this should be set automatically either in our release process by parsing from Cargo.toml, or by the installer itself checking for $VERSION and then making a separate HTTP request to figure out the latest version released on github. i'm not sure which one i like better, the first one is more performant (eliminates one round trip to github), whereas the second one might be a bit easier.
The text was updated successfully, but these errors were encountered: