-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: build binaries for Big Sur
architecture
#260
Comments
Big Sur
Big Sur
architecture
SituationWe currently build release builds for ProblemBig Sur requires building for a completely different architecture even if a given MacOS instance is running on the same hardware that worked with the SolutionWe need to build My guess is that we will need to provide both binaries in our releases (unless the new architecture also happens to work on old versions of MacOS, which I doubt). Additionally, the curl installer and the npm installer will both need updates that detect which MacOS binary should be downloaded. Some extra research to be done there to see how best to determine that. Unfortunately, GitHub Actions has put Big Sur builds into a private preview due to demand outpacing capacity. This significantly impedes our ability to make progress on this issue at the moment. We will also need to start signing our binaries if we want our curl installer to work on Big Sur (generally a good practice anyways). Info on how to sign binaries can be found here |
It's possible to build a Universal Binary that contains executable code for both architectures. It should be possible to build them on either hardware. |
I do want to bring over (my own) comment that I feel is relevant from #230 (comment) (which was merged into this issue):
@EverlastingBugstopper noted as a response to this, that:
It's fair to have hesitation here, but the burden of Docker as a dependency is already upon us since we're running |
I'm failing at really correctly framing my actual point today (so I'm going to reconsider using my words today and I probably shouldn't have suggested this in the way I did above, so I edited my above comment to remove ramblings). My actual point is: I think we should be cautious about introducing addition variant binaries when possible. Mac, Linux and Windows seem like good ambitions and I think we should consider multiarchitecture binaries when possible to stay within those constraints, if that makes more concrete sense. |
Reopening this as I think we should be able to produce a universal binary with
|
Originally posted by @EverlastingBugstopper in #582 (comment) |
It seems like the built artifact does not work with Big Sur. We should add this distro to our testing matrix in github actions.
The text was updated successfully, but these errors were encountered: