-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental support for query batching #3837
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacks a lot of polish, but does run the happy path correctly. Things needing deeper consideration: - configuration - cloning parts - error handling - array processing
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
Geal
reviewed
Sep 15, 2023
Not returning the correct errors (as per design doc) when batching not enabled, but basically working.
also: - add code to make extension_code configurable from translate_request cargo fmt has given up on this file, so the next change will be a re-factoring to try and tidy up the source code.
also: break up some of the mega-functions into smaller functions. Not strictly part of this issue, but it needed to be done.
It's pretty rough, so will need some good reviewing from docs to bring to life.
smyrick
reviewed
Sep 19, 2023
...uter/src/configuration/snapshots/apollo_router__configuration__tests__schema_generation.snap
Outdated
Show resolved
Hide resolved
There are a couple of things that need to be verified:
|
Co-authored-by: Maria Elisabeth Schreiber <[email protected]>
Co-authored-by: Maria Elisabeth Schreiber <[email protected]>
Co-authored-by: Maria Elisabeth Schreiber <[email protected]>
Co-authored-by: Maria Elisabeth Schreiber <[email protected]>
Co-authored-by: Maria Elisabeth Schreiber <[email protected]>
Co-authored-by: Maria Elisabeth Schreiber <[email protected]>
Co-authored-by: Maria Elisabeth Schreiber <[email protected]>
…/router into garypen/126-query-batching
Co-authored-by: Maria Elisabeth Schreiber <[email protected]>
…/router into garypen/126-query-batching
Co-authored-by: Maria Elisabeth Schreiber <[email protected]>
Sometimes it fails.
BrynCooke
approved these changes
Sep 26, 2023
it didn't, but maybe is a step in the right direction so leaving it in for now.
bnjjj
reviewed
Sep 27, 2023
It's really hard to test report generation for metrics. Traces at least are aggregated within a span, so no special handling is required. The existing metrics tests only send in 1 request, so they work by accident. The batch metric test generates two requests (batch of 2) and so this makes the existing testing mechanisms very sad. I've decided on a compromise for batch testing. Just check that the number of requests sums to 2 across all of the metrics reports which are generated. Not ideal, but something we could try to improve in the future.
bnjjj
approved these changes
Sep 27, 2023
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things needing attention
parts
is acceptable (in review) It isn't, so not cloned but re-built.SupergraphRequest
is acceptable (in review)@defer
orsubscription
detected in batch?Fixes #126
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Manual testing was performed with
curl
and apollo clientNotes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩