diff --git a/NEXT_CHANGELOG.md b/NEXT_CHANGELOG.md index 942a264d7b..b0c881a9a5 100644 --- a/NEXT_CHANGELOG.md +++ b/NEXT_CHANGELOG.md @@ -28,5 +28,14 @@ By [@USERNAME](https://github.com/USERNAME) in https://github.com/apollographql/ ## ❗ BREAKING ❗ ## 🚀 Features ## 🐛 Fixes + +### Respect supergraph path for kubernetes deployment probes (#1787) + +For cases where you configured the `supergraph.path` for the router when using the helm chart, the liveness +and readiness probes continued to use the default path of `/` and so the start failed. + +By @damienpontifex in #1788 + + ## 🛠 Maintenance ## 📚 Documentation diff --git a/helm/chart/router/templates/deployment.yaml b/helm/chart/router/templates/deployment.yaml index 83cf20e9cb..b03dba5db9 100644 --- a/helm/chart/router/templates/deployment.yaml +++ b/helm/chart/router/templates/deployment.yaml @@ -92,14 +92,14 @@ spec: httpHeaders: - name: Content-Type value: application/json - path: "/?query={__typename}" + path: {{ .Values.router.configuration.supergraph.path | default "/" }}?query={__typename} port: {{ .Values.containerPorts.http }} readinessProbe: httpGet: httpHeaders: - name: Content-Type value: application/json - path: "/?query={__typename}" + path: {{ .Values.router.configuration.supergraph.path | default "/" }}?query={__typename} port: {{ .Values.containerPorts.http }} resources: {{- toYaml .Values.resources | nindent 12 }}