Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing an instrument selector to impl Drop #4866

Closed
bnjjj opened this issue Mar 27, 2024 · 1 comment
Closed

Allowing an instrument selector to impl Drop #4866

bnjjj opened this issue Mar 27, 2024 · 1 comment
Labels
component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it. story/observability

Comments

@bnjjj
Copy link
Contributor

bnjjj commented Mar 27, 2024 •
edited
Loading

In order to tag a metric or span that has been cancelled or dropped it would be great to have a specific selector for this. It would imply implementing Drop on selectors or on_drop.

related to #4319
@bnjjj bnjjj added component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it. story/observability labels Mar 27, 2024
@bnjjj
Copy link
Contributor Author

bnjjj commented Jul 9, 2024

It has been implemented

@bnjjj bnjjj closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it. story/observability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bnjjj